Remove inappropriate status tripping up turbo #17339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
changed the title
ulferts
force-pushed
the
bug/59369-work-package-settings-page-is-broken
branch
2 times, most recently
from
81fa18b to
613cbaf
Compare
ulferts
force-pushed
the
bug/59369-work-package-settings-page-is-broken
branch
from
613cbaf to
7cd9daf
Compare
HDinger
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/59369
What are you trying to accomplish?
Fix the issue described in the linked bug.
What approach did you choose and why?
Returning
unprocessable_entityon a GET request, with no parameters provided is not appropriate and trips up turbo leading to a reinitialization of the angular app and ckeditor.It was added when enabling turbo drive (#16486) where when rendering a response to a POST form request a non ok status needs to be returned. I believe here, it was added erroneously.
Merge checklist